Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: added auto merge for cartesian_chunk #699

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

qinxuye
Copy link
Contributor

@qinxuye qinxuye commented Sep 16, 2023

What do these changes do?

This PR added auto merge for cartesian_chunk

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Sep 16, 2023
@XprobeBot XprobeBot added this to the v0.6.2 milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #699 (87ec47d) into main (dd999f0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files        1025     1025              
  Lines       79341    79353      +12     
  Branches    16442    16440       -2     
==========================================
+ Hits        74191    74197       +6     
- Misses       3463     3466       +3     
- Partials     1687     1690       +3     
Flag Coverage Δ
unittests 93.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/xorbits/_mars/dataframe/base/cartesian_chunk.py 94.61% <100.00%> (-0.20%) ⬇️
python/xorbits/_mars/dataframe/base/core.py 100.00% <100.00%> (ø)
python/xorbits/_mars/dataframe/merge/merge.py 98.31% <100.00%> (-0.08%) ⬇️

... and 10 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 14d64ae into xorbitsai:main Sep 18, 2023
31 checks passed
@qinxuye qinxuye deleted the enh/cartesian-auto-merge branch September 18, 2023 03:19
ChengjieLi28 added a commit to ChengjieLi28/xorbits that referenced this pull request Oct 8, 2023
ChengjieLi28 added a commit to ChengjieLi28/xorbits that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants