Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix pd.read_csv cannot read pathlib.Path #757

Merged
merged 14 commits into from
Nov 21, 2023

Conversation

traderbxy
Copy link
Contributor

What do these changes do?

Fix the BUG: pd.read_csv cannot read pathlib.Path

Related issue number

Fixes #734

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.1 milestone Nov 15, 2023
@traderbxy traderbxy changed the title Fix pd.readcsv Fix pd.read_csv Nov 15, 2023
@luweizheng luweizheng changed the title Fix pd.read_csv BUG: Fix pd.read_csv cannot read pathlib.Path Nov 15, 2023
@XprobeBot XprobeBot added the bug Something isn't working label Nov 15, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e4a996f) 93.55% compared to head (2be01d6) 93.59%.

Files Patch % Lines
...hon/xorbits/_mars/dataframe/datasource/read_csv.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   93.55%   93.59%   +0.03%     
==========================================
  Files        1059     1059              
  Lines       79781    79786       +5     
  Branches    16504    16506       +2     
==========================================
+ Hits        74640    74674      +34     
+ Misses       3461     3432      -29     
  Partials     1680     1680              
Flag Coverage Δ
unittests 93.48% <60.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng self-requested a review November 21, 2023 02:27
@ChengjieLi28 ChengjieLi28 merged commit 1964357 into xorbitsai:main Nov 21, 2023
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pd.read_csv cannot read pathlib.Path
4 participants