Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove sum_over_features parameter from manhattan_distances with sklearn > 1.4 #779

Merged
merged 11 commits into from
Jun 17, 2024

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

@Dawnfz-Lenfeng Dawnfz-Lenfeng commented Jun 16, 2024

What do these changes do?

  • The sum_over_features parameter is no longer supported in scikit-learn versions >= 1.4.
  • Removed sum_over_features from manhattan_distances to align with the latest version of scikit-learn.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Jun 16, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (79c3bc8) to head (bc69412).

Files Patch % Lines
.../xorbits/_mars/learn/metrics/pairwise/manhattan.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #779       +/-   ##
===========================================
- Coverage   84.60%   68.84%   -15.77%     
===========================================
  Files        1059     1059               
  Lines       79804    79731       -73     
  Branches    16497    12139     -4358     
===========================================
- Hits        67521    54892    -12629     
- Misses      10707    23329    +12622     
+ Partials     1576     1510       -66     
Flag Coverage Δ
unittests 68.83% <0.00%> (-15.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH: Remove sum_over_features from manhattan_distances to align with latest sklearn ENH: Remove sum_over_features parameter from manhattan_distances with sklearn > 1.4 Jun 16, 2024
@luweizheng luweizheng self-requested a review June 17, 2024 02:46
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit f2fa7cf into xorbitsai:main Jun 17, 2024
15 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants