-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Remove sum_over_features
parameter from manhattan_distances
with sklearn > 1.4
#779
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
===========================================
- Coverage 84.60% 68.84% -15.77%
===========================================
Files 1059 1059
Lines 79804 79731 -73
Branches 16497 12139 -4358
===========================================
- Hits 67521 54892 -12629
- Misses 10707 23329 +12622
+ Partials 1576 1510 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sum_over_features
from manhattan_distances
to align with latest sklearnsum_over_features
parameter from manhattan_distances
with sklearn > 1.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
sum_over_features
parameter is no longer supported in scikit-learn versions >= 1.4.sum_over_features
frommanhattan_distances
to align with the latest version of scikit-learn.Related issue number
Fixes #xxxx
Check code requirements