Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix Docker CI/CD workflow #796

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

@Dawnfz-Lenfeng Dawnfz-Lenfeng commented Aug 18, 2024

What do these changes do?

The Dockerfile is outdated, and this PR fixes this issue.

  • fix the following error:
    Error while loading conda entry point: conda-libmamba-solver (libarchive.so.19: cannot open shared object file: No such file or directory)

  • change installation source to official source:
    /opt/conda/bin/conda install -c conda-forge --solver classic

Test the docker container with pytest unit tests.

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 18, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (2f99f8c) to head (05d85b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   80.70%   80.71%           
=======================================
  Files        1070     1070           
  Lines       80019    80019           
  Branches    16525    16525           
=======================================
+ Hits        64581    64586    +5     
+ Misses      13877    13868    -9     
- Partials     1561     1565    +4     
Flag Coverage Δ
unittests 80.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH: Fix Deployment Error in Docker Setup BLD: Fix Docker CI/CD workflow Aug 18, 2024
@XprobeBot XprobeBot added build and removed enhancement New feature or request labels Aug 18, 2024
@luweizheng luweizheng self-requested a review August 18, 2024 07:37
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit bf9317e into xorbitsai:main Aug 18, 2024
29 of 36 checks passed
@Dawnfz-Lenfeng Dawnfz-Lenfeng deleted the docker branch September 15, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants