Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix slurm CI/CD workflow #801

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

@Dawnfz-Lenfeng Dawnfz-Lenfeng commented Aug 20, 2024

What do these changes do?

  • The previous setup relied on the default base environment provided by the conda environment in the image daskdev/dask-jobqueue:slurm.
  • However, the intended environment is dask-jobqueue.
  • To ensure the correct environment is used, a new custom slurmbase image is now manually created, and the dask-jobqueue environment is activated within the image.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (310a866) to head (629d44c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files        1070     1070           
  Lines       80004    80004           
  Branches    16521    16521           
=======================================
+ Hits        64575    64578    +3     
+ Misses      13872    13863    -9     
- Partials     1557     1563    +6     
Flag Coverage Δ
unittests 80.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 221387f into xorbitsai:main Aug 20, 2024
28 of 36 checks passed
@Dawnfz-Lenfeng Dawnfz-Lenfeng deleted the slurm branch September 15, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants