-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Fix slurm CI/CD workflow #801
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 1070 1070
Lines 80004 80004
Branches 16521 16521
=======================================
+ Hits 64575 64578 +3
+ Misses 13872 13863 -9
- Partials 1557 1563 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
base
environment provided by the conda environment in the imagedaskdev/dask-jobqueue:slurm
.dask-jobqueue
.slurmbase
image is now manually created, and thedask-jobqueue
environment is activated within the image.Related issue number
Fixes #xxxx
Check code requirements