Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: update web ui deps & remove deprecated numpy.compat #835

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

luweizheng
Copy link
Collaborator

  • update web ui package.json dependencies
  • remove deprecated numpy.compat

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Dec 15, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (68a434a) to head (1110802).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   78.51%   82.79%   +4.28%     
==========================================
  Files        1071     1071              
  Lines       80176    80176              
  Branches    12209    12209              
==========================================
+ Hits        62948    66384    +3436     
+ Misses      15514    12242    -3272     
+ Partials     1714     1550     -164     
Flag Coverage Δ
unittests 82.68% <ø> (+4.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng removed this from the v0.7.4 milestone Dec 16, 2024
Copy link
Collaborator

@hucorz hucorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hucorz hucorz merged commit 607c3b9 into xorbitsai:main Dec 16, 2024
38 of 40 checks passed
@luweizheng luweizheng deleted the js branch December 16, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants