-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Assistant updates #1885
Merged
Merged
Home Assistant updates #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mcspr
commented
Sep 2, 2019
- remove "platform" key, see Depreciated warnings from home-assistant #1440. this implicitly sets schema to "basic". pending some other clean-up regarding json and mqtt queueing, other schema can be added down the line
- updated ws module queue elem to capture callbacks list, allows to pass more than one callback (for example, when they are generated on the fly as lambdas, see ha wsPost usage)
- modified method to send ha config to use global ws queue, fix show config topic field blank when code uploaded from platformio #1762 problem with empty topics and ensure json allocation is consistent.
- use existing defines to set mqtt payload options. amend Support publishing custom value for relay processing #1085, Define HOMEASSISTANT_PAYLOAD_AVAILABLE for payload_available #1188 to use the set payload value. drop HOMEASSISTANT_PAYLOAD... defines. fixes MQTT relay payload ON / OFF inconsistent usage #1883
- update MQTT_STATUS_ONLINE/OFFLINE and RELAY_MQTT_ON/OFF with runtime configuration
- filter payload strings so that resulting yaml value is not interpreted as bool
- helper method for settings to streamline string values manipulation
cc @Yonsm, as that was the latest change to the status payload string. now, only one define needs to be specified |
mcspr
added a commit
that referenced
this pull request
Sep 3, 2019
- customize relay TOGGLE payload - match payload string when receiving mqtt status message - reference enum values instead of raw integers, spell out intended status - remove dead code amend #1885, capitalize `relayPayload...` suffix instead of using uppercase add `relayPayloadToggle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.