Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing / not implemented default getSettings values #1996

Merged
merged 6 commits into from
Nov 17, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Nov 17, 2019

  • update thingspeak, api, scheduler to use header defined default values
  • fix scheduler defaults to use the same values as webui presets when creating a new schedule
  • fix generateapi() in webui to trigger only when apiKey getSetting output is empty (API_KEY or apiKey missing or empty string)
  • minor fix from WebUI fix change detection of input elements #1986 to the originals setter to handle checkboxes output

mostly from #1986, avoid mixing originals webui problem with these

@mcspr mcspr merged commit ab186e0 into xoseperez:dev Nov 17, 2019
@mcspr mcspr deleted the settings-fix branch November 17, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant