Kingart curtain switch UI support #2250

echauvet · 2020-05-13T17:39:59Z

This is a preliminary commit to extend KA work by @AlbertWeterings. Using AT+START commands, we know the real position of the curtain. Small MCU bugs are bypassed as commented in the code.
The UI is animated and displays :

A basic animation of the curtain opening (4 types available) - this reflects the real position of the curtain if the switch is correctly calibrated ( the MCU adds 2 seconds to the initial calibration)
The 3 buttons are displayed and animated (blue/red colors) as the curtain switch. (this is achieved with AT+START commands and move status detection)
A slider to set an absolute position. Its position is refreshed whenever the curtain stops moving.

A configuration panel as been created to choose:

The curtain type. I will use it later for mqtt to integrate a basic UI layout of the curtain
Once rebooted/powered on, the curtain initial position could be set

Next steps are code cleaning, integrate any reviews from contributors and improve the MQTT stack with RedNode. For now, I can drive my curtain as a Google curtain, or a switch or a lamp bulb (for brightness setting). I'm preparing some demo flow with Google legacy curtain, and the hybrid solution.

Both core base and latest-base are working - with latest-base, a two steps upgrade is required.
I'm cheking the work done for OTA in RedNode to check if some code is ready for 2 steps upgrade.

All Tests has been done using a curtain switch, espurna UI, google home and RedNode UI and all seems to animate together without bugs.

Added Web UI controls and view in status Added power up behaviour (nothing, close, open, last position) Added curtain style (Roller, etc...) for UI status and to be used in MQTT

…ling position from received messages. Added comment to debug tab to show how to enable debug

mcspr

Thanks!

If you don't mind going over code comments once more, please verify that those still apply.
We should explain magic numbers in code (and, if possible, in log too). I've added some helpers for getSetting() 2nd arg, we can map any type from string. see namespace settings { namespace internal in relays / buttons / sensors.
We don't enforce any specific style / formatting... But one thing I am not a fan of is if (cond) expr;, unless those are one-liners like if (something) return;. Having brackets is preferable.

code/html/custom.js

code/espurna/curtain_kingart.cpp

Co-authored-by: Max Prokhorov <prokhorov.max@outlook.com>

Added public set position function and curtain count

…ot (00:00 after refresh). Default Hour is 12h

Schedule support. Light support is having an issue with new schedules corrected here.

mcspr

Let's think a bit more about the scheduler stuff? I am not sure restoring works like that, but I'd expect normal operation mode does. This can be a separate patch, not to complicate things further.

If you are ok with kingart .cpp stuff, I'll reformat it for the merge.

code/espurna/scheduler.cpp

code/html/custom.js

code/espurna/curtain_kingart.cpp

mcspr · 2020-05-16T15:11:44Z

code/espurna/scheduler.cpp

@@ -311,7 +337,7 @@ void schSetup() {

        static bool restore_once = true;
        if (restore_once) {
-            for (unsigned char i = 0; i < relayCount(); i++) {
+            for (unsigned char i = 0; i < schedulableCount(); i++) {


Doesn't this step on schCheck id resolution? If we have 1 relay and 1 curtain, for example.

I've done a big answer and as a result:

So the quick answer is that I tested all with a dummy switch in hardware.h and you can choose between both types and it works:

Switch and curtain schedule task worked.
This is how the light schedule bug has been detected (it stays as a switch schedule instead of light schedule)

In this specific block, schCheck will recursively check every 'rule' that uses specific relayID (index from old relayCount()) and goes back a week day-by-day to check if rule applies in the past.
Although, we don't count light channels, so it's still sort-of broken because of non-matching ID / indexes.

Understood! In fact, we need specific processing for curtain.

AlbertWeterings · 2020-05-17T08:19:11Z

Great work you are doing Eric, your work makes the Curtain switch usable for many people that are not using it only over MQTT. I did not have the knowledge and time to build the web interface so I took off after MQTT was finished and my 9 shutters where moving the way I wanted them to move.

In your code I fount this:
// Need to send confirmation to the N76E003AT20 that message is received
// ECH : TODO Check this is the case every time
_KACurtainSend("AT+SEND=ok");

I can confirm it is mandatory to confirm to the N76E003AT20 that every message send by it is received. When I started working on it I found that after power up the switch it takes about 30sec before the N76E003AT20 starts sending messages (just not log enough to flash the ESP) so at first I had jumpers on the data lines to disconnect both chips from each other and be able to flash ESPURNA. After silencing the N76E003AT20 flashing is possible. Now a day's we have to OTA flash in two stages this is possible as long the N76E003AT20 stay's quiet after a power cycle flashing is not possible anymore as the N76E003AT20 is corrupting the flash process.

I have been logging communication between both chips with the original software for quite some time to fully understand how it works.

mcspr · 2020-05-17T14:20:30Z

Now a day's we have to OTA flash in two stages this is possible as long the N76E003AT20 stay's quiet after a power cycle flashing is not possible anymore as the N76E003AT20 is corrupting the flash process.

re. some discussions in the Core repository and general observations about reboot.
Perhaps we need to do Serial.end() before doing OTA? Chip persist some of the configuration between sw reboots, including pins state / uart / etc.

AlbertWeterings · 2020-05-17T14:42:05Z

b.t.w. Flashing over serial also fails as the N76E003AT20 starts sending data during flashing. This can be solved by holding it's pin 4 or on the rear side of the board RES1 to GND this keeps the N76E003AT20 in reset state.

mcspr

Merging as-is b/c curtain part is done, delaying scheduler changes (?) for later.

echauvet · 2020-05-18T11:58:14Z

@AlbertWeterings the solution I found is to calibrate the curtain to a very long period for intial flash so the MCU does not send messages until the closed position is not reached. Do you confirm that this is the AT+UPDATE message "setclose":0 "switch":"off" sent at the end of the first move which breaks the update? If so, just calibrate curtain opening to > 60s - this will be enough to keep MCU quiet.

AlbertWeterings · 2020-05-20T06:51:19Z

@echauvet This is a nice work around at the moment you are blocked from flashing after something went wrong. I think good to document. I preferer to silence the MCU in the software by confirming the last message is understood. I did a quick test, you can preform a OTA 2 stage update without problems when ESP is rebooting the MCU doesn't. Only if someone is touching the buttons the MCU starts repeating it's last message and flashing is not possible. Disabling the serial port during OTA flash procedure as @mcspr referred to is the best sollution.

echauvet and others added 4 commits May 13, 2020 17:20

Completed kingart curtain switch support:

f1cc8a8

Added Web UI controls and view in status Added power up behaviour (nothing, close, open, last position) Added curtain style (Roller, etc...) for UI status and to be used in MQTT

Checked commit before PR. Added html gulp static files generated.

42f9818

Corrected a code refactor error which make the MQTT messages not hand…

56888b1

…ling position from received messages. Added comment to debug tab to show how to enable debug

Use the maximum compression for gzip. A byte is a byte :)

2b3f1de

mcspr requested changes May 14, 2020

View reviewed changes

echauvet and others added 7 commits May 14, 2020 17:38

Update code/espurna/curtain_kingart.cpp

d1f7d1f

Co-authored-by: Max Prokhorov <prokhorov.max@outlook.com>

Variable name prefix update

0384e7d

Added public set position function and curtain count

Added Scheduler new type : curtain

142c892

Add curtain schedule support and correct the 12h bug when adding a sl…

435f1c5

…ot (00:00 after refresh). Default Hour is 12h

Code cleaning.

e29b673

Schedule support. Light support is having an issue with new schedules corrected here.

I let do better by the specialists

f907661

Curtain init statues

5b3fcab

mcspr reviewed May 16, 2020

View reviewed changes

echauvet added 2 commits May 16, 2020 22:54

Coding style corrections

683ce9f

Removed debug stuff from now - will be back later with the right way

d950c81

mcspr added 2 commits May 17, 2020 18:00

rebuild webui

976e014

revert 435f1c5 schHour default, rebuild ui

3f16e5f

mcspr approved these changes May 17, 2020

View reviewed changes

mcspr merged commit 21e75be into xoseperez:dev May 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kingart curtain switch UI support #2250

Kingart curtain switch UI support #2250

echauvet commented May 13, 2020 •

edited

Loading

mcspr left a comment

mcspr left a comment

mcspr May 16, 2020

echauvet May 16, 2020 •

edited

Loading

mcspr May 17, 2020

echauvet May 18, 2020

AlbertWeterings commented May 17, 2020

mcspr commented May 17, 2020

AlbertWeterings commented May 17, 2020

mcspr left a comment

echauvet commented May 18, 2020

AlbertWeterings commented May 20, 2020

Kingart curtain switch UI support #2250

Kingart curtain switch UI support #2250

Conversation

echauvet commented May 13, 2020 • edited Loading

mcspr left a comment

Choose a reason for hiding this comment

mcspr left a comment

Choose a reason for hiding this comment

mcspr May 16, 2020

Choose a reason for hiding this comment

echauvet May 16, 2020 • edited Loading

Choose a reason for hiding this comment

mcspr May 17, 2020

Choose a reason for hiding this comment

echauvet May 18, 2020

Choose a reason for hiding this comment

AlbertWeterings commented May 17, 2020

mcspr commented May 17, 2020

AlbertWeterings commented May 17, 2020

mcspr left a comment

Choose a reason for hiding this comment

echauvet commented May 18, 2020

AlbertWeterings commented May 20, 2020

echauvet commented May 13, 2020 •

edited

Loading

echauvet May 16, 2020 •

edited

Loading