Added info about Caps Lock in login screen #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This looks absolutely fine, thank you for your contribution!! :) I merely have one question atm: is the explicit dependency on gdk4-sys needed? can we work around that by updating our version of gdk4? |
|
Ohh i just realized we don't need that. |
Updated cargo-sources.json Remove gdk4-sys from sources (oops)
|
Removed |
|
Perfect then :) there's just something I forgot, could you run |
|
Should be fine now :) |
|
Perfect, thanks!! merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I saw that there's no info about "Caps Lock being enabled" on Spot login screen, so...
I implemented it.
Please let me know if something's wrong with my code (I hope not haha)