-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlist edition #590
Playlist edition #590
Conversation
7a31ca5
to
d10a482
Compare
I'll pull it to look into :) |
What about adding some Remove Track and Add track options into those three-dots every track has? Would be very useful |
so the way I see it is the three-dots menu is for non-actions, just obtaining more info about a track. I'm thinking of removing the queue option that's been here for a while eventually instead I think actions should be implemented with the selection mode that we have, so that things can be done in bulk! removing a track from a playlist works by entering selection mode, selecting one or multiple songs and using the appropriate option at the bottom; similarly adding one or more tracks is done with the selection mode also I wish there was some way to make this discoverable, but long pressing a track enables selection mode + selects that track, so it's not all that much slower than using the three-dots menu |
I totally aggree, it is more efficient to do stuff in bulk, though, I like the option for the quick one-offs to be as "fast" as a complex operation. Totally up to you though, I'm fine with the current implementation :) |
thanks for the review I appreciate it!!! almost done here I think, save for a few details, but I want to merge it soon enough as it does rework a few important things |
No problem! I hope I'm doing it right :) |
…eate a new playlist when it is clicked
793ce99
to
30628b2
Compare
yeah I definitely appreciate the feedback! :) |
i honestly dont remember what was left to do here