Test PartialNode string representation with options

xp-forge · Oct 28, 2023 · 94830df · 94830df
1 parent f9c9db7
commit 94830df
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/main/php/com/handlebarsjs/PartialNode.class.php b/src/main/php/com/handlebarsjs/PartialNode.class.php
@@ -49,11 +49,7 @@ public function options() { return $this->options; }
   protected function optionString() {
     $r= '';
     foreach ($this->options as $key => $option) {
-      if (false !== strpos($option, ' ')) {
-        $r.= ' '.$key.'= "'.$option.'"';
-      } else {
-        $r.= ' '.$key.'= '.$option;
-      }
+      $r.= ' '.$key.'= '.(string)$option;
     }
     return $r;
   }
@@ -64,7 +60,7 @@ protected function optionString() {
    * @return string
    */
   public function toString() {
-    return nameof($this).'(> '.$this->template->toString().$this->optionString().'}}, indent= "'.$this->indent.'")';
+    return nameof($this).'({{> '.$this->template->toString().$this->optionString().'}}, indent= "'.$this->indent.'")';
   }
 
   /**

diff --git a/src/test/php/com/handlebarsjs/unittest/PartialNodeTest.class.php b/src/test/php/com/handlebarsjs/unittest/PartialNodeTest.class.php
@@ -1,6 +1,6 @@
 <?php namespace com\handlebarsjs\unittest;
 
-use com\handlebarsjs\{Lookup, PartialNode};
+use com\handlebarsjs\{Lookup, PartialNode, Quoted};
 use test\{Assert, Test};
 
 class PartialNodeTest {
@@ -15,11 +15,19 @@ public function template() {
   #[Test]
   public function string_representation() {
     Assert::equals(
-      'com.handlebarsjs.PartialNode(> com.handlebarsjs.Lookup(test)}}, indent= "")',
+      'com.handlebarsjs.PartialNode({{> com.handlebarsjs.Lookup(test)}}, indent= "")',
       (new PartialNode(new Lookup('test')))->toString()
     );
   }
 
+  #[Test]
+  public function string_representation_with_options() {
+    Assert::equals(
+      'com.handlebarsjs.PartialNode({{> com.handlebarsjs.Lookup(test) mount= "/"}}, indent= "")',
+      (new PartialNode(new Lookup('test'), ['mount' => new Quoted('/')]))->toString()
+    );
+  }
+
   #[Test]
   public function string_cast() {
     Assert::equals('{{> test}}', (string)new PartialNode(new Lookup('test')));