Support for X-ray polarimetry #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculation of polarized X-ray pulses (with Stokes parameters I, Q, and U) implemented. An example and tutorial has also been drafted. The code should be still optimized, and better documented, and the implementation of tools for fitting polarimetric observations should be finished.
This option still to be passed properly to HotRegion and other integrators. Then stokes and normal integrators could be merged.
…to get I." This reverts commit 1dd0312.
Co-authored-by: Bas Dorsman <superbas1996@gmail.com>
and to simulate polarized data.
Turning occult=False for ixpeobssim gives a match to B23.
Modeling without statistics need to be still rerun to make sure it works.
thjsal
changed the title
Basdorsman
reviewed
Feb 5, 2024
Basdorsman
reviewed
Feb 5, 2024
Basdorsman
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of polarized X-ray pulses (with Stokes parameters I, Q, and U) implemented. An example and tutorial has also been drafted. The code should still be optimized, and better documented, and the statistical analysis part should be checked/finished.
Currently, there are separate integrators for Stokes parameter calculation. It might be better to merge them with the normal integrators to avoid repeating similar codes very many times. But need to think if that can be done so that extra computation is avoided when polarized signals are not needed.