Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GENERIC] Simplify readIniString usage. #43

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[GENERIC] Simplify readIniString usage. #43

merged 2 commits into from
Sep 19, 2023

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented Sep 19, 2023 •
edited
Loading

Changes

  • Do not use prefix param for readIniString where not needed
  • Use null over empty string where possible
  • Shorter call signature for read ini string where possible
  • Simplify readIniString method
  • Rename additional to smartTerrainName where changes applied.
  • Rename gulag to smartTerrain where changes applied.

Checklist

  • tests are included
  • documentation is changed or added

@Neloreck
Do not use prefix param for readIniString where not needed. Use nul…
074961e 
…l over empty string where possible. Shorter call signature for read ini string where possible. Simplify method. Rename additional to smartTerrainName where possible. Rename `gulat` to `smartTerrain` where possible.
@Neloreck Neloreck self-assigned this Sep 19, 2023
@github-actions github-actions bot added test Changes are updating or introducing unit tests engine managers Changes are affecting game managers schemes Changes are affecting game logics schemes scripts ai Changes are affecting stalkers AI/state logic labels Sep 19, 2023
@Neloreck Neloreck marked this pull request as ready for review September 19, 2023 01:56
@github-actions github-actions bot added the cli Changes are affecting XRF cli tools label Sep 19, 2023
@Neloreck Neloreck removed the engine label Sep 19, 2023
@Neloreck Neloreck merged commit 0b8c490 into main Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Neloreck Neloreck

Labels
ai Changes are affecting stalkers AI/state logic cli Changes are affecting XRF cli tools managers Changes are affecting game managers schemes Changes are affecting game logics schemes scripts test Changes are updating or introducing unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neloreck