Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMART_TERRAINS] Simplify and decouple jobs/spawn logics #82

Merged
merged 17 commits into from
Dec 2, 2023
Merged

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented Dec 1, 2023

Changes

  • Move job utils/methods to separate modules instead of smart terrain class
  • Add unit tests for smart terrain utils
  • JSdoc updated
  • Simplify logics
  • Fix issue with new TSTL this ref

Checklist

  • tests are included
  • documentation is changed or added

@Neloreck Neloreck self-assigned this Dec 1, 2023
@github-actions github-actions bot added test Changes are updating or introducing unit tests managers Changes are affecting game managers schemes Changes are affecting game logics schemes ui Changes are affecting game UI / forms scripts labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (fca282d) 57.22% compared to head (a4a88c9) 57.54%.

Files Patch % Lines
.../engine/core/objects/smart_terrain/SmartTerrain.ts 56.00% 44 Missing ⚠️
.../engine/core/utils/scheme/scheme_initialization.ts 17.85% 23 Missing ⚠️
.../schemes/restrictor/sr_particle/ParticleManager.ts 0.00% 14 Missing ⚠️
...ne/core/objects/smart_terrain/job/job_execution.ts 88.00% 9 Missing ⚠️
src/engine/core/objects/squad/Squad.ts 0.00% 6 Missing ⚠️
src/engine/core/managers/travel/TravelManager.ts 0.00% 4 Missing ⚠️
...jects/smart_terrain/object/smart_terrain_object.ts 87.50% 4 Missing ⚠️
src/engine/core/managers/map/MapDisplayManager.ts 33.33% 2 Missing ⚠️
...mes/stalker/remark/actions/ActionRemarkActivity.ts 33.33% 2 Missing ⚠️
...core/managers/notifications/NotificationManager.ts 80.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   57.22%   57.54%   +0.32%     
==========================================
  Files        1159     1166       +7     
  Lines       38220    38252      +32     
  Branches     6628     6636       +8     
==========================================
+ Hits        21872    22013     +141     
+ Misses      16348    16239     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neloreck Neloreck marked this pull request as ready for review December 2, 2023 23:39
@Neloreck Neloreck merged commit 8ceede3 into main Dec 2, 2023
@Neloreck Neloreck deleted the dev branch December 2, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
managers Changes are affecting game managers schemes Changes are affecting game logics schemes scripts test Changes are updating or introducing unit tests ui Changes are affecting game UI / forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant