Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow short Pre-edge Range Selections #517

Open
LJRH opened this issue Jun 21, 2024 · 3 comments
Open

Allow short Pre-edge Range Selections #517

LJRH opened this issue Jun 21, 2024 · 3 comments
Milestone

Comments

@LJRH
Copy link

LJRH commented Jun 21, 2024

Version: Larix Larch 0.9.78
Module: xasviewer / pre_edge()
Dataset: HERFD-XANES Fe K-edge (short energy range)
Load Method: Data loaded both directly into Larch and from Athena Project

Description: On choosing a pre-edge range for a short Fe K-edge (7107 -> 7140 eV) in the xasviewer GUI will not allow a pre-edge region of less than 5 eV. Choosing a pre-edge range less than 5 eV causes a default value of pre2 to be set. Loading the dataset from an Athena project (with correct/chosen pre-edge values set), causes pre-edge values to be overwritten.

image

Request: For in situ HERFD-XANES datasets, it is sometimes necessary to have very short pre-edge regions which is made possible by the low noise floor in these datasets (coupled with carefully chosen longer scans to compare normalisation values with). It would be good to be able to choose short pre-edge regions of less than 5 eV in length, perhaps with a warning to the user that this could cause a normalisation issue.

Many thanks to the developers for their efforts.

L

@newville
Copy link
Member

@LJRH thanks. Yeah, we should handle this case better. Maybe instead of "minimum of 5 eV" it should be "minimum of 2 data points"?

@LJRH
Copy link
Author

LJRH commented Jun 25, 2024

Hi Matt, Yes - I think "minimum of 2 data points" is sensible, as long as it does not interfere with victoreen choice? Does the relevant code fall within pre_edge.py [182:202], is it just rounding to the nearest 5eV?

@maurov maurov added this to the 0.9.80 milestone Jul 18, 2024
@maurov
Copy link
Member

maurov commented Jul 18, 2024

@LJRH this should be fixed now. Please, could check and close the issue then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants