Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDI read of bad file causes seg fault #519

Open
jacobfilik opened this issue Jun 25, 2024 · 3 comments
Open

XDI read of bad file causes seg fault #519

jacobfilik opened this issue Jun 25, 2024 · 3 comments
Milestone

Comments

@jacobfilik
Copy link

jacobfilik commented Jun 25, 2024

larch version: 0.9.74

I am writing a web application using larch and XDI files, as part of my testing I have been sending incorrectly formed XDI files to the application.

A simple file containing just:

# XDI/1.0

Seems to make the XDI reader seg fault taking out the interpreter.

@jacobfilik
Copy link
Author

Once an additional line is added, i.e.

# XDI/1.0\n#

An error is raised but the interpreter does not crash, suggesting its possibly just single line files causing the issue, which I can easily test for outside the library.

@newville
Copy link
Member

@jacobfilik Thanks - I can certainly believe that a single file line was not included in the test suite! But of course, we should not be seg-faulting the interpreter when reading any file! Will investigate...

@maurov maurov added this to the 0.9.80 milestone Jul 18, 2024
@maurov
Copy link
Member

maurov commented Jul 18, 2024

@jacobfilik this should be fixed in the latest release. Please, could you test and eventually close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants