Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw10 program optimization #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xrezus
Copy link
Owner

@xrezus xrezus commented Aug 29, 2022

Домашнее задание №10 «Оптимизация программы»

Чек-лист студента (Что это?)

Критерии оценки

  • Пайплайн зелёный и нет попытки «обмануть» систему - 4 балла
  • Добавлены юнит-тесты - до 3 баллов
  • Понятность и чистота кода - до 3 баллов

Зачёт от 7 баллов

Copy link
Collaborator

@agneum agneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за вариант решения.
Хорошая работа, однако пайплайн не пройден
https://github.com/xrezus/hw-otus/actions/runs/3169577183/jobs/5161583520#step:5:13

Возвращаю задание на доработку


func getUsers(r io.Reader) (result users, err error) {
content, err := ioutil.ReadAll(r)
reg, err := regexp.Compile("@(?P<Domain>.+\\." + domain + ")$")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно использовать strings.HasSuffix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants