Handle fields of type binary #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests only failed on Java 6. Is it still supported by clojure? |
|
@ipostelnik Thanks for this (and sorry for the delay).
Next version was gonna be 0.3.0 anyways, so that's okay.
Sure, but - for now - no longer by thrift-clj. I'm fine with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This push adds support for fields tagged with "binary" type in thrift IDL. These fields are represented as byte arrays and ByteBuffer in generated code. However, they are tagged as STRING in thrift metadata.
Note: This is a compatibility-breaking change. The non-string values for string fields will no longer be converted to string using
str. The client code is responsible for ensuring that string fields are set to string values.