Imported client functions should be accessible only via namespace #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not propagate to current namespace.
|
You're right, they should not be referred into the current namespace (but they seem to be). I'll see if I can find the time to evaluate/fix this - but don't expect anything before the weekend. :) Thanks for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just want to clarify if current namespace should adopt functions from imported service. I'd expect them to be accessible via namespace only (
TBin this case). I don't have much experience with Clojure so perhaps I'm doing something wrong? I've added a failing test case, but unfortunately I don't have enough experience yet to fix it (if it needs fixing at all).Thanks!