Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New convergence check for pencil beam. #121

Merged

Conversation

gbrogginess
Copy link
Contributor

Description

The logic to determine if a pencil beam is converging or diverging has been generalized to additionally cover the case in which collimators are angularly tilted.

The pull request also contains other small fixes (typos in line_tools.py).

Closes # .

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@freddieknets freddieknets changed the base branch from main to release/v0.5.11 November 27, 2024 17:47
@freddieknets freddieknets merged commit f21df12 into xsuite:release/v0.5.11 Nov 27, 2024
@gbrogginess gbrogginess deleted the new_convergence_check branch November 28, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants