Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch start==end in creation of second-order taylor map #565

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

michi42
Copy link
Contributor

@michi42 michi42 commented Dec 15, 2024

SecondOrderTaylorMap.from_line() uses compute_one_turn_matrix_finite_differences() which for start==end returns a full one-turn response matrix. This is a "surprising" behavior in the context of creating a one-turn map, where one might rather expect an identity map (K=0, R=eye, T=0) in this case.

@szymonlopaciuk szymonlopaciuk mentioned this pull request Dec 17, 2024
@szymonlopaciuk szymonlopaciuk merged commit e5321e2 into xsuite:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants