Added isclose test for std::complex<float> #2751
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test demonstrating compiler error from isclose on xarray<std:;complex> as per request on #2730
Compiler:
Microsoft (R) C/C++ Optimizing Compiler Version 19.37.32825 for x64
Error:
C2678 binary '+': no operator found which takes a left-hand operand of type 'std::complex' (or there is no acceptable conversion) xtl\xtype_traits.hpp 94
C2672 'std::max': no matching overloaded function found xtensor\include\xtensor\xmath.hpp 1760
C3536 'd': cannot be used before it is initialized xtensor\include\xtensor\xmath.hpp 1758