Fix duplicate decorations getting created

xtermjs · Mar 21, 2022 · 23076ba · 23076ba
1 parent fe530d9
commit 23076ba
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/addons/xterm-addon-search/src/SearchAddon.ts b/addons/xterm-addon-search/src/SearchAddon.ts
@@ -92,6 +92,7 @@ export class SearchAddon implements ITerminalAddon {
   private _disposeDecorations(): void {
     this._resultDecorations.forEach(decorations => {
       for (const d of decorations) {
+        console.log('dispose', d);
         d.dispose();
       }
     });
@@ -189,9 +190,6 @@ export class SearchAddon implements ITerminalAddon {
         }
       }
     }
-    if (result && searchOptions?.decorations) {
-      this._createResultDecoration(result, searchOptions?.decorations);
-    }
     return result;
   }
 
@@ -646,6 +644,7 @@ export class SearchAddon implements ITerminalAddon {
     if (!marker || !decorations?.matchColor) {
       return undefined;
     }
+
     const findResultDecoration = terminal.registerDecoration(
       { marker,
         overviewRulerOptions: this._resultDecorations.get(marker.line) && !this._dataChanged ? undefined : { color: decorations.matchColor, position: 'center' }