Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In DynamicCharAtlas, don't store empty characters in the texture #1389

Closed
bgw opened this issue Apr 16, 2018 · 1 comment
Closed

In DynamicCharAtlas, don't store empty characters in the texture #1389

bgw opened this issue Apr 16, 2018 · 1 comment
Labels
type/enhancement Features or improvements to existing features
Milestone
4.0.0

Comments

@bgw
Copy link
Member

bgw commented Apr 16, 2018

Discussion here: #1327 (comment)

We don't need to save anything to the atlas texture if a glyph is empty, we just need to keep track of the fact that it was empty. This may or may not be worth the added complexity, but we should try and see.
@bgw bgw mentioned this issue Apr 16, 2018
Merged
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/renderer labels Jun 8, 2018
@Tyriar Tyriar mentioned this issue Nov 20, 2018
Merged
@Tyriar Tyriar added this to the 4.0.0 milestone Jun 23, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2019

No plans to implement this for canvas renderer as we'll move towards the webgl addon that was just moved eventually

@Tyriar Tyriar closed this as completed Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@bgw @Tyriar