Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull mouse mode handling into its own module #1504

Closed
Tyriar opened this issue Jun 8, 2018 · 1 comment
Closed

Pull mouse mode handling into its own module #1504

Tyriar opened this issue Jun 8, 2018 · 1 comment
Labels
area/mouse-support help wanted type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 8, 2018

The xterm mouse handling code is fairly self contained and could be pulled into its own module:

xterm.js/src/Terminal.ts

Lines 783 to 793 in ddc9466

/**
* XTerm mouse events
* http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#Mouse%20Tracking
* To better understand these
* the xterm code is very helpful:
* Relevant files:
* button.c, charproc.c, misc.c
* Relevant functions in xterm/button.c:
* BtnCode, EmitButtonCode, EditorButton, SendMousePosition
*/
public bindMouse(): void {

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Jul 5, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2019

Done by @jerch

@Tyriar Tyriar closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mouse-support help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

1 participant