[WIP] Pull mouse mode handling into its own module #1608
Conversation
| private _vt300Mouse: boolean; // This is unstable and never set | ||
|
|
||
| constructor( | ||
| private _terminal: any |
There was a problem hiding this comment.
How should I go about typing this? Should I add the missing properties to the IInputHandlingTerminal, ITerminal, or should I create a new interface?
There was a problem hiding this comment.
The ideal situation is that MouseEventsHandler does not depend on Terminal at all, instead it only communicates back via events, this would help break the circular dependency.
Also eventually we should pull all the mouse-related properties of Terminal into MouseEventsHandler, and move the non-DOM dependent parts into ./core/input/Mouse.ts, (like ./core/input/), and the DOM dependent parts to ./ui/Mouse.ts(or./ui/UserInterface`). This direction is explained in more detail in #1507
|
Closing this off as stale, feel free to open a new PR after rebasing if you want to continue no this 😃 |
Fixes #1504
Work in progress, I have a small question directly in the code...
Feedback is welcome 😄