Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when bell sound is used #1694

Closed
Tyriar opened this issue Sep 15, 2018 · 1 comment
Closed

Exception when bell sound is used #1694

Tyriar opened this issue Sep 15, 2018 · 1 comment
Labels
help wanted type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 15, 2018

Repro:

  1. Enable bell in vscode
  2. Open a terminal
  3. Try trigger bell
Uncaught DOMException: Failed to construct 'AudioContext': The number of hardware contexts provided (6) is greater than or equal to the maximum bound (6).
    at SoundManager.playBellSound (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/SoundManager.js:11:34)
    at Terminal.bell (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Terminal.js:1035:31)
    at InputHandler.bell (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/InputHandler.js:299:24)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/InputHandler.js:131:94
    at EscapeSequenceParser.parse (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/EscapeSequenceParser.js:310:25)
    at InputHandler.parse (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/InputHandler.js:200:22)
    at Terminal._innerWrite (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Terminal.js:876:32)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Terminal.js:858:23

screen shot 2018-09-15 at 9 42 01 am

@jerch
Copy link
Member

jerch commented Nov 9, 2018

@Tyriar Seems the number of audio contexts one can create has a global hard limit. As a possible workaround Terminal could provide a single AudioContext statically to all instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants