hold single AudioContext instance #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Up for review. |
Tyriar
approved these changes
Nov 17, 2018
|
Ok done. |
Tyriar
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1694.
It should be save to just hold one
AudioContextinstance for all terminal instances within a document (created on the first bell request onSoundManager).NB:
The change will not work if there are still more audio contexts spawned than allowed on integrator side (e.g. vscode). If thats an issue we might want to refactor SoundManager to take an optional argumentAdded optional ctor argument.context. This way the integrator can maintain the audio contexts itself.