Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using accessiblity mode a property 'textContent' can be undefined #2082

Closed
marusak opened this issue May 14, 2019 · 0 comments · Fixed by #2085
Closed

Using accessiblity mode a property 'textContent' can be undefined #2082

marusak opened this issue May 14, 2019 · 0 comments · Fixed by #2085
Assignees
@Tyriar
Labels
area/accessibility type/bug Something is misbehaving
Milestone
3.13.1

Comments

@marusak
Copy link

marusak commented May 14, 2019

Using accessibility mode can sometime end up with trace as:

TypeError: Cannot set property 'textContent' of undefined
at AccessibilityManager../node_modules/xterm/lib/AccessibilityManager.js.AccessibilityManager._renderRows (...)
at RenderDebouncer../node_modules/xterm/lib/ui/RenderDebouncer.js.RenderDebouncer._innerRefresh (...)

This is new regression seen only in version 3.13.0, version 3.12.2 was not affected.
In general this is hard to reproduce, it happens in our CI, or I can only reproduce it with very high load on my machine and running tests in loop.

Possible place of happening https://github.com/xtermjs/xterm.js/blob/master/src/AccessibilityManager.ts#L252

I know this is no reproducer, possibly just conditionally check that these elements are present? Seems related to 4c3082c924ac or more general to #2026
marusak added a commit to marusak/cockpit that referenced this issue May 14, 2019
@marusak
Revert "package.json: Update xterm package dependency"
ab35125 
This reverts commit 55f71b8.

The reverted commit was introduced in cockpit-project#11797 but later on was noticed
that sometimes xterm can crash. Reported to xtermjs/xterm.js#2082
@marusak marusak mentioned this issue May 14, 2019
Merged
martinpitt pushed a commit to cockpit-project/cockpit that referenced this issue May 14, 2019
@marusak @martinpitt
Revert "package.json: Update xterm package dependency"
0f9b4ec 
This reverts commit 55f71b8.

The reverted commit was introduced in #11797 but later on was noticed
that sometimes xterm can crash. Reported to xtermjs/xterm.js#2082

Closes #11822
@Tyriar Tyriar added the type/bug Something is misbehaving label May 15, 2019
@Tyriar Tyriar added this to the 3.13.1 milestone May 15, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 15, 2019
@Tyriar
Add sanity check in AccessibilityManager
8002580 
Fixes xtermjs#2082
@Tyriar Tyriar self-assigned this May 15, 2019
@Tyriar Tyriar mentioned this issue May 15, 2019
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 16, 2019
@Tyriar
Add sanity check in AccessibilityManager
ab7da81 
Fixes xtermjs#2082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/accessibility type/bug Something is misbehaving
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Add sanity check in AccessibilityManager Tyriar/xterm.js
2 participants
@Tyriar @marusak