Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handler name #2112

Closed
Tyriar opened this issue May 21, 2019 · 1 comment · Fixed by #2247
Closed

Improve handler name #2112

Tyriar opened this issue May 21, 2019 · 1 comment · Fixed by #2247
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 21, 2019

Terminal.handler is very ambiguous, a better name such as triggerUserInput or something would be better to differentiate it from calling _onData.fire directly. The main difference is that it scrolls to the bottom on user input, but not on device status reporting.
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 21, 2019
@mofux
Copy link
Contributor

mofux commented May 21, 2019

I agree. triggerUserInput sounds like a good name to me.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 23, 2019
@Tyriar
Move handler into CoreService and adopt
bfa7a2d 
This also fine tunes some of the data events to not clear selection
and scroll to the bottom of the viewport anymore.

Part of xtermjs#1507
Fixes xtermjs#2112
@Tyriar Tyriar mentioned this issue Jun 23, 2019
Merged
@Tyriar Tyriar added this to the 4.0.0 milestone Jun 23, 2019
@Tyriar Tyriar self-assigned this Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Move handler into CoreService and adopt Tyriar/xterm.js
2 participants
@Tyriar @mofux