Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are not running on Windows #2543

Closed
Tyriar opened this issue Nov 5, 2019 · 0 comments · Fixed by #2541
Closed

Unit tests are not running on Windows #2543

Tyriar opened this issue Nov 5, 2019 · 0 comments · Fixed by #2541
Assignees
@Tyriar
Labels
type/automation Relating to CI/CD pipeline, automation, etc.
Milestone
4.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 5, 2019

https://dev.azure.com/xtermjs/xterm.js/_build/results?buildId=2643

Probably the slashes or not using .cmd in ./bin/test.js
@Tyriar Tyriar added the type/automation Relating to CI/CD pipeline, automation, etc. label Nov 5, 2019
@Tyriar Tyriar added this to the 4.3.0 milestone Nov 5, 2019
@Tyriar Tyriar self-assigned this Nov 5, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 6, 2019
@Tyriar
Get Windows unit tests running again
fe2f1ea 
Fixes xtermjs#2543
@Tyriar Tyriar mentioned this issue Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/automation Relating to CI/CD pipeline, automation, etc.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Skip puppeteer download on unit test runs, fix windows tests, polish pipeline Tyriar/xterm.js
1 participant
@Tyriar