Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor disappears when using vim with DOM renderer #2581

Closed
Tyriar opened this issue Nov 24, 2019 · 1 comment · Fixed by #2582
Closed

Cursor disappears when using vim with DOM renderer #2581

Tyriar opened this issue Nov 24, 2019 · 1 comment · Fixed by #2582
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
4.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 24, 2019

microsoft/vscode#84299

Repro:

  1. Enable dom renderer
  2. Open vim
  3. Press up/down a few times
@Tyriar Tyriar added type/bug Something is misbehaving area/renderer labels Nov 24, 2019
@Tyriar Tyriar added this to the 4.3.0 milestone Nov 24, 2019
@Tyriar Tyriar self-assigned this Nov 24, 2019
@Tyriar Tyriar mentioned this issue Nov 24, 2019
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 24, 2019
@Tyriar
Mark before and after cursor rows dirty when changed
217bc24 
The DOM renderer renders the cursor as part of the content, not on a
separate layer, so it needs to be marked dirty to draw.

Fixes xtermjs#2581
@Tyriar Tyriar mentioned this issue Nov 24, 2019
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Nov 24, 2019

This was caused by fixing the bug in #2536 where all rows were getting rendered always, this was just one case where we weren't considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Mark before and after cursor rows dirty when changed Tyriar/xterm.js
1 participant
@Tyriar