Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas and DOM renderers should force transparency in the selection color #2594

Closed
Tyriar opened this issue Dec 3, 2019 · 1 comment
Closed

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 3, 2019

Downstream: microsoft/vscode#86072

The webgl renderer supports opaque colors as it's drawn behind, the other renderers draw on top due to their own limitations. Could we just force 50% transparency or do some clever blending to get the approximate color for dom and canvas?

@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2022

This is already done:

/**
* If selection color is opaque, blend it with background with 0.3 opacity
* Issue #2737
*/
if (color.isOpaque(this.colors.selectionTransparent)) {
const opacity = 0.3;
this.colors.selectionTransparent = color.opacity(this.colors.selectionTransparent, opacity);
}

Only follow up for canvas: #3937

@Tyriar Tyriar closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant