Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Switching terminal background color doesn't react appropriately #86072

Closed
joaomoreno opened this issue Dec 3, 2019 · 5 comments
Closed

Terminal: Switching terminal background color doesn't react appropriately #86072

joaomoreno opened this issue Dec 3, 2019 · 5 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@joaomoreno
Copy link
Member

Testing #85971

  1. Open a terminal
  2. Select some text
  3. Open settings and change terminal.selectionBackground through workbench.colorCustomizations
  • When using canvas, it appears the entire selection is gone
  • When using experimentalWebgl, selected text gets cheesy and the selection background color doesn't change:

image
@joaomoreno joaomoreno changed the title Terminal: Switching terminal background color doesn't react accordingly Terminal: Switching terminal background color doesn't react appropriately Dec 3, 2019
This was referenced Dec 3, 2019
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Dec 3, 2019

@joaomoreno I think the canvas case is fine as opaque selections don't work, I was thinking about forcing opacity when using canvas/dom to help with this xtermjs/xterm.js#2594

Upstream for webgl: xtermjs/xterm.js#2595

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Dec 3, 2019
@Tyriar Tyriar added this to the Backlog milestone Dec 3, 2019
@Tyriar Tyriar modified the milestones: Backlog, April 2020 Apr 25, 2020
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 25, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 25, 2020

The canvas thing you mention is an inconsistency, but I want to remove the canvas renderer soonish so it's not worth the effort to fix such an obscure bug.

@Tyriar Tyriar closed this as completed in 2c76881 Apr 26, 2020
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label Apr 26, 2020
@joaomoreno
Copy link
Member Author

There are still rendering glitches which go away once I reselect:
recording (6)

@joaomoreno joaomoreno added the verified Verification succeeded label Apr 30, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2020

Yeah that was the original bug, I might not have updated xterm properly.

@Tyriar Tyriar reopened this Apr 30, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 30, 2020
@Tyriar Tyriar removed the verified Verification succeeded label Apr 30, 2020
@Tyriar Tyriar modified the milestones: May 2020, Backlog May 11, 2020
@Tyriar Tyriar removed the upstream-issue-fixed The underlying upstream issue has been fixed label Sep 1, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@4.6.0-beta.25 xterm-addon-webgl@0.7.0-beta.8
d013476 
Diff: xtermjs/xterm.js@e7f72a1...51dc03a

Fixes microsoft#95556
Fixes microsoft#86072
@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2022

This is fixed, the selection disappearing for canvas only is tracked in xtermjs/xterm.js#4057

@Tyriar Tyriar closed this as completed Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @meganrogge