Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm-addon-attach syntax error in IE #2646

Closed
jestapinski opened this issue Dec 23, 2019 · 3 comments · Fixed by #2654
Closed

xterm-addon-attach syntax error in IE #2646

jestapinski opened this issue Dec 23, 2019 · 3 comments · Fixed by #2654
Assignees
Labels
area/addon/attach type/bug Something is misbehaving
Milestone

Comments

@jestapinski
Copy link

jestapinski commented Dec 23, 2019

When trying to use the attach addon in IE11, it results in a plain "syntax error". This is likely due to a webpack or tsconfig issue since copying the code into my local project works as expected.

Other addons (such as fit) use ES5 whereas this uses ES6.

Details

  • Browser and browser version: IE11
  • OS version: Windows 7
  • xterm.js version: 4.3.0
  • attach version: 0.4.0

Steps to reproduce

  1. Open xterm.js with the attach addon loaded
  2. Inspect the console
@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2019

The tsconfig.json target is likely the problem as you indicated.

@Tyriar Tyriar added this to the 4.4.0 milestone Dec 27, 2019
@Tyriar Tyriar self-assigned this Dec 27, 2019
@Tyriar Tyriar added area/addon/attach type/bug Something is misbehaving labels Dec 27, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 27, 2019
@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2019

@jestapinski could you please verify with xterm-addon-attach@0.5.0-beta.1? I don't have a Windows machine around atm.

@jestapinski
Copy link
Author

Hi @Tyriar, just gave it a look. Looks great, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/attach type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants