Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowOptions not typed in get/setOption API #3369

Closed
jerch opened this issue Jun 13, 2021 · 1 comment · Fixed by #3546
Closed

windowOptions not typed in get/setOption API #3369

jerch opened this issue Jun 13, 2021 · 1 comment · Fixed by #3546
Assignees
@jerch
Labels
area/api type/enhancement Features or improvements to existing features

Comments

@jerch
Copy link
Member

jerch commented Jun 13, 2021

windowOptions currently gets handled by the any type fallthough in getOption and setOption, which is subpar.
@jerch jerch added the area/api label Jun 13, 2021
@jerch jerch self-assigned this Jun 13, 2021
@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2021

This actually happens for all options, because the any one exists none of the options get compile time checks. We should move to setters and getter imo:

terminal.options.windowOptions = ...

@silamon silamon mentioned this issue Sep 1, 2021
Merged
@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run type/enhancement Features or improvements to existing features and removed type/debt Technical debt that could slow us down in the long run labels Oct 20, 2021
@silamon silamon mentioned this issue Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerch jerch

Labels
area/api type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting multiple options through term.options silamon/xterm.js
2 participants
@Tyriar @jerch