-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose typed options from OptionsService through terminal.options #3448
Conversation
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks I've wanted this for quite a while 🎉
This PR creates a significant perf decrease in common modules, which have to ask option service for options (e.g. xterm.js/src/common/services/OptionsService.ts Lines 98 to 107 in 0bc02d6
Fix: dont use getter/setter in fast path code. |
This PR makes it possible to use typed options in the terminal addons. Much or less the example from one of the related issues.
As far as I am aware, this doesn't introduce breaking changes (yet).
There are some following up possibilities:
Related: #2522, #3369