Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude box drawing characters from min contrast ratio #3843

Closed
Tyriar opened this issue May 31, 2022 · 0 comments · Fixed by #3844
Closed

Exclude box drawing characters from min contrast ratio #3843

Tyriar opened this issue May 31, 2022 · 0 comments · Fixed by #3844
Assignees
@Tyriar @meganrogge
Labels
area/addon/canvas area/addon/webgl area/renderer-dom type/bug Something is misbehaving
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2022

VS Code issue: microsoft/vscode#150777

This framework uses box drawing characters as a scroll bar, these characters should probably be excluded from the min contrast ratio feature:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
area/addon/canvas area/addon/webgl area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

exclude box and block glyphs from contrast ratio demands meganrogge/xterm.js
2 participants
@Tyriar @meganrogge