Use explicit null check to ensure start/end row is valid #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this could have caused the inconsistent behavior with links not activating and then working again after scrolling Fixes xtermjs#1233
Tyriar
commented
Jan 22, 2018
| @@ -82,12 +82,12 @@ export class Linkifier extends EventEmitter implements ILinkifier { | |||
| } | |||
|
|
|||
| // Increase range to linkify | |||
| if (!this._rowsToLinkify.start) { | |||
| if (this._rowsToLinkify.start === null) { | |||
There was a problem hiding this comment.
This is the only line that functionally changed, before this condition would fire when this._rowsToLinkify.start was 0, meaning it could have been linkifying all rows:
this._rowsToLinkify.start = 0
this._rowsToLinkify.end = term rows - 1
And then the next call to the function would override it, which means only one row would be checked if start === end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this could have caused the inconsistent behavior with
links not activating and then working again after scrolling
Fixes #1233