-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testbed: 32 bit memory layout for buffer #1854
Conversation
~0.43ms/frame -> ~0.37ms/frame
Results in xterm-benchmark:
|
I think this is definitely the way to go to start with, double the (small amount of) memory for a little faster runtime and it's way more simple especially since we don't have to deal with how attributes are stored and invalidated. |
@Tyriar Yes, with this approach here the extended attrs are much easier and less error prone to implement, prolly can be done in one true color PR. |
Closing the PR as I think we all agree to go with this approach for now. |
Testbed PR to be able to identify differences between 32 and 16 bit memory layout for the buffer in runtime and memory usage.
Implements:
InputHandler.print
(therefore the JS array buffer will not work here)Buffer layout:
Else its based on current master, additionally it includes the webgl renderer as default (makes it easier to spot buffer related things in the timeline).
Simply run the demo app and compare the timeline results with the 16 bit variant #1855.
Note: To see the impact of the utf8 input handling alone, the timeline results can be compared to the webgl PR branch.
/cc @Tyriar, @mofux, @bgw
Edit: The tests will not pass, I did not apply the change all over the codebase, just to the critical parts. If the build does not finish, run
npm run watch
andnpm run watch-addons
instead.