Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight all matches in demo by default #3786

Merged
merged 1 commit into from
May 12, 2022
Merged

Highlight all matches in demo by default #3786

merged 1 commit into from
May 12, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 12, 2022

No description provided.

@Tyriar Tyriar added this to the 4.19.0 milestone May 12, 2022
@Tyriar Tyriar requested a review from meganrogge May 12, 2022 17:54
@Tyriar Tyriar self-assigned this May 12, 2022
meganrogge
meganrogge reviewed May 12, 2022
View reviewed changes
Copy link
Member

@meganrogge meganrogge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if the overview ruler decorations showed up immediately.. they currently don't because we require that option to be explicitly set

https://github.com/tyriar/xterm.js/blob/edba006045ea2a9acf459385bae442ed0d5ad5d7/src/browser/Terminal.ts#L610-L616

overview.mov

@Tyriar Tyriar merged commit 7d4b614 into xtermjs:master May 12, 2022
@Tyriar Tyriar deleted the default_highlight branch May 12, 2022 20:25
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @meganrogge