Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move w objects to $ prefix variables #4162

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 1, 2022

Fixes #4138

@Tyriar Tyriar added this to the 5.1.0 milestone Oct 1, 2022
@Tyriar Tyriar self-assigned this Oct 1, 2022
@Tyriar Tyriar enabled auto-merge October 1, 2022 14:27
@Tyriar Tyriar merged commit 035025d into xtermjs:master Oct 1, 2022
@Tyriar Tyriar deleted the w_refactor branch October 1, 2022 15:57
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 6, 2022
- Bump copyright year xtermjs/xterm.js#4176
- Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170
- Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169
- Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168
- Create new event with emitter object to simplify code xtermjs/xterm.js#4166
- Define all events and emitters consistently xtermjs/xterm.js#4165
- Inline dirty row service into input handler xtermjs/xterm.js#4163
- Move w objects to $ prefix variables xtermjs/xterm.js#4162

Fixes #158984
Fixes #158874
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
- Bump copyright year xtermjs/xterm.js#4176
- Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170
- Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169
- Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168
- Create new event with emitter object to simplify code xtermjs/xterm.js#4166
- Define all events and emitters consistently xtermjs/xterm.js#4165
- Inline dirty row service into input handler xtermjs/xterm.js#4163
- Move w objects to $ prefix variables xtermjs/xterm.js#4162

Fixes microsoft#158984
Fixes microsoft#158874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change w work object pattern to regular variables prefixed with $
1 participant