Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReferenceError in publish.js #5252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ReferenceError in publish.js #5252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ function checkAndPublishPackage(packageDir, repoCommit, peerDependencies) {
stdio: 'inherit'
});
if (result.status) {
error(`Spawn exited with code ${result.status}`);
process.exit(result.status);
Copy link
Contributor Author

@jtbandes jtbandes Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that exiting with the same status code is not too important, because the child process's status code is part of the error message already?

throw new Error(`Spawn exited with code ${result.status}`);
}

return { isStableRelease, nextVersion };
Expand Down
Loading