Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare pt and valid vars in correct spot #668

Merged
merged 3 commits into from
May 22, 2017
Merged

Declare pt and valid vars in correct spot #668

merged 3 commits into from
May 22, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 21, 2017 •
edited
Loading

Preparation for #207

@Tyriar Tyriar added this to the 2.7.0 milestone May 21, 2017
@Tyriar Tyriar self-assigned this May 21, 2017
@Tyriar Tyriar requested a review from parisk May 21, 2017 18:28
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 68.887% when pulling 13088f5 on Tyriar:fix_pt_valid_var_declarations into a95ac99 on sourcelair:master.

@Tyriar Tyriar mentioned this pull request May 21, 2017
Merged
64 tasks
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 68.887% when pulling d2b0d51 on Tyriar:fix_pt_valid_var_declarations into a95ac99 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 68.987% when pulling ccf1a04 on Tyriar:fix_pt_valid_var_declarations into db0338c on sourcelair:master.

@Tyriar Tyriar merged commit 35b32b7 into xtermjs:master May 22, 2017
@Tyriar Tyriar deleted the fix_pt_valid_var_declarations branch May 22, 2017 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk