Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding article #95

Merged
merged 10 commits into from
Nov 7, 2019
Merged

encoding article #95

merged 10 commits into from
Nov 7, 2019

Conversation

jerch
Copy link
Member

@jerch jerch commented Oct 2, 2019

WIP.

Tyriar
Tyriar reviewed Oct 2, 2019
View reviewed changes
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
@jerch jerch added the work-in-progress Do not merge label Oct 2, 2019
@jerch jerch mentioned this pull request Oct 4, 2019
Closed
@Tyriar Tyriar mentioned this pull request Nov 5, 2019
Closed
Tyriar
Tyriar approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point, we can merge this in after the minor feedback is addressed and always improve upon it later if we want to.

_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
_docs/guides/encoding.md Outdated Show resolved Hide resolved
@jerch
Copy link
Member Author

jerch commented Nov 7, 2019

@Tyriar
Done with it. Plz have a look at the luit/iconv parts, made them a bit more verbose with examples.

Tyriar
Tyriar approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jerch jerch merged commit e7b5aee into xtermjs:master Nov 7, 2019
@jerch jerch deleted the encoding branch November 7, 2019 16:05
@Tyriar Tyriar removed the work-in-progress Do not merge label Dec 5, 2019
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerch @Tyriar