Improves the utf8 decoder performance #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decode algorithm to iterative.
This was referenced Apr 26, 2023
|
Thanks for the PR @Dig-Doug . For the record and since the CI is broken, the tests pass locally with your changes. |
xtuc
approved these changes
May 9, 2023
|
Released in 1.11.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing large wasm files, the decode function is very slow. You can reproduce the performance issues with the information in webpack/webpack#17044. This change refactors the recursive algorithm to an iterative version that should have the exact same behavior with significantly better performance.