Made billing budget filter labels updatable (GoogleCloudPlatform#5545)

xuchenma · Jan 7, 2022 · 88ea875 · 88ea875
1 parent bbbc055
commit 88ea875
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/mmv1/products/billingbudget/terraform.yaml b/mmv1/products/billingbudget/terraform.yaml
@@ -81,6 +81,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         default_from_api: true
         update_mask_fields:
           - "budgetFilter.projects"
+          - "budgetFilter.labels"
       budgetFilter.services: !ruby/object:Overrides::Terraform::PropertyOverride
         default_from_api: true
       budgetFilter.subaccounts: !ruby/object:Overrides::Terraform::PropertyOverride

diff --git a/mmv1/third_party/terraform/tests/resource_billing_budget_test.go b/mmv1/third_party/terraform/tests/resource_billing_budget_test.go
@@ -128,6 +128,9 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = ["projects/${data.google_project.project.number}"]
+    labels  = {
+      label = "bar"
+    }
   }
 
   amount {
@@ -173,6 +176,7 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = []
+    labels = {}
   }
 
   amount {
@@ -218,6 +222,9 @@ resource "google_billing_budget" "budget" {
 
   budget_filter {
     projects = []
+    labels  = {
+      label1 = "bar2"
+    }
   }
 
   amount {