-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified date of redistributed xunit.abstractions.dll is wrong #399
Comments
I appreciate this investigation, but to what end? It's already too late to do anything. |
What do you mean by too late? The time stamp in the xunit.abstractions nuget package on nuget.org is correct. |
It's possible that NuGet is modifying the packages when it signs them. |
My point of it being "too late" is that the four versions of |
Actually, I'm looking at the package that I downloaded from the CI build, and it appears that the binary signing process is what's changing the dates. Local build (built just now):
Downloaded CI build (built yesterday):
Also looks like some of the dates may be being restored improperly on GitHub (like the files under the |
Nevermind on that part, Git does not preserve file times. The differences are fresh pull vs. how long they've been sitting on my machine. So note that: putting something into the repository will destroy its date/time. |
This is true, but it only touches CI package:
NuGet version (which was uploaded from the CI package):
Looks very much like a time zone bug, but probably one nobody cares about. |
Given that this is the binary signing process at work, I'm going to mark this as an external issue. You may wish to open an issue here: https://github.com/dotnet/sign Note, however, that the signing process will change the file contents, so it still won't make the up-to-date check work. So chase it if you wish, it's not going to solve the original problem. |
Why do we need to sign xunit.abstractions.dll again? It's already coming in from the nuget.org package so I would expect it to already be signed. Or am I wrong on that? |
That would be a question to ask of the |
To be clear: the signing request we make is "sign this NuGet package" and they sign the package itself as well as any signable binaries inside of it. We don't pick which DLLs get signed. |
Looks like this issue might be related: dotnet/sign#647 |
Available in
|
Yep, was planning to do that after lunch. 😄 |
For a better solution to xunit/xunit#1651, @akoeplinger and I were trying to understand why the modified date of xunit.abstractions.dll in the xunit.runner.visualstudio.nupkg package is different to the one in the xunit.abstractions.nupkg on nuget.org.
When I locally build this repository, I see the correct last modified date in the produced package:
But when I look at the officially released package on nuget.org, the last modified date is wrong (same for the most recent version on feedz.io):
ℹ️ I unzipped with WinRAR which better handles preserving timestamps than Windows Explorer
@bradwilson any idea where this difference could be coming from?
The text was updated successfully, but these errors were encountered: