Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DesignMode. #100

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Conversation

codito
Copy link
Contributor

@codito codito commented Feb 16, 2017

Turn off Source Information query when design mode is false (command line scenario).

More details on RunConfiguration.DesignMode is available microsoft/vstest#344.

Turn off Source Information query when design mode is false (command line scenario).
@dnfclas
Copy link

dnfclas commented Feb 16, 2017

Hi @codito, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@codito
Copy link
Contributor Author

codito commented Feb 16, 2017

We're adding support for DesignMode in test platform as part of fix for #344. There isn't a PR out for it yet, I am sharing the PR to xunit first to get early feedback :)

/cc @bradwilson @onovotny @KevinH-MS @Shyam-Gupta

@bradwilson
Copy link
Member

@codito This looks good to us. We may do some additional optimizations related to this. Should we merge this, or are you still discussing it?

@bradwilson bradwilson merged commit b326add into xunit:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants